• Ephera@lemmy.ml
    link
    fedilink
    English
    arrow-up
    86
    ·
    2 days ago

    I have a working student at $DAYJOB and last week, I asked her to look into a bug, where our UI would reset the input fields after 5 minutes, because of an auth token refresh.

    And then she came back with a PR, with a single line changed, and she was not impressed with her work, because it took almost no effort. She said, she just guessed what change to make, waited 5 minutes and then it worked.

    Meanwhile, I was the giddiest I’ve been in a while, because I thought we’d never fix that bug. It just sounded like one of those ugly bugs, where we might have to patch the auth library again and where it’s almost impossible to know what else is broken afterwards.
    But with a single-line-change, it’s immediately obvious that it won’t break anything else. I could just immediately merge that to be shipped with the next release. Which is just excellent.

    • Awesome Lowlander@cozyver.se
      link
      fedilink
      English
      arrow-up
      37
      ·
      2 days ago

      Meanwhile, I was the giddiest I’ve been in a while, because I thought we’d never fix that bug. It just sounded like one of those ugly bugs, where we might have to patch the auth library again and where it’s almost impossible to know what else is broken afterwards. But with a single-line-change, it’s immediately obvious that it won’t break anything else. I could just immediately merge that to be shipped with the next release. Which is just excellent.

      Did you tell her that? :D

      • Ephera@lemmy.ml
        link
        fedilink
        English
        arrow-up
        14
        ·
        2 days ago

        Yeah, it was actually in a sync meeting that we looked at the PR together, so she got my giddy voice and repeated reassurances that I’m not just messing with her.

        It’s an open-source project, so I’ve always made it a point to write “Thanks for your contribution!” under her PRs as well. And this time, she watched me type out “Excellent change!” before that and hit “Send”, which is when she actually believed me that I’m serious.

      • takeda@lemmy.dbzer0.com
        link
        fedilink
        English
        arrow-up
        27
        ·
        edit-2
        2 days ago

        No, by not telling her she will be more motivated in the future and go target even more challenging bugs increasing company profits /s

        But seriously, OP wrote it with such enthusiasm that I would be very surprised that he didn’t say it to her and everyone around.

    • sbv@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      11
      ·
      2 days ago

      But with a single-line-change, it’s immediately obvious that it won’t break anything else.

      🤞